Jhtml::image bug ?

[josephvalet]

Hi ,
thank you for your great work.

Maybe I'm wrong but I think I found a bug in :
com_phocagallery/views/category/tmpl/default_comments.php (line 16) in Phoca Gallery 3.2.0/J2.5.4 (so a php error appears in the comments on category view).

This line dont give the "alt" for the smileys icons and Joomla needs it:

Code: Select all

$comment = str_replace($smileyKey, JHtml::_( 'image', 'components/com_phocagallery/assets/images/'.$smileyValue .'.'.$this->tmpl['formaticon']), $comment);

I added some '' to it :

Code: Select all

$comment = str_replace($smileyKey, JHtml::_( 'image', 'components/com_phocagallery/assets/images/'.$smileyValue .'.'.$this->tmpl['formaticon'],''), $comment);

and the following error i had has disapered :
Warning: Missing argument 2 for JHtml::image() in D:\Infonet36\www\mdln\www\libraries\joomla\html\html.php on line 474
The Joomla function is :

Code: Select all

function image($file, $alt, $attribs = null, $relative = false, $path_only = false){}

Thank you to correct me if I'm wrong with this.

Joseph Valet

[Jan]

Hi, yes, you right, the alt needs to be added as there is no default value, I will fix it in next version.

Thank you for the info.

Jan

[bender]

thanks, josephvalet

[Jan]

Will be set in 3.2.1

Jan