'Close the window' link in download screen

Phoca Gallery - image gallery extension
User avatar
forlx.62
Phoca Member
Phoca Member
Posts: 21
Joined: 29 Oct 2022, 22:35

'Close the window' link in download screen

Post by forlx.62 »

Hi,

here is a new topic about the link 'Close the window' in the download screen.

There is also a 'close' button in the right-bottom of the download screen.

I don't understand why this link.

If i click the link 'close the window', then the website is now displayed in the download window

is it possible to disable this link and only have the 'close' button in the right-bottom ?

Regards
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 47887
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: 'Close the window' link in download screen

Post by Jan »

Hi, can you paste a screenshot of what do you exactly mean?

Jan
If you find Phoca extensions useful, please support the project
User avatar
forlx.62
Phoca Member
Phoca Member
Posts: 21
Joined: 29 Oct 2022, 22:35

Re: 'Close the window' link in download screen

Post by forlx.62 »

Hi,

here is the picture Image

as you can see there is a link to close the window and i have a button in the right-bottom corner to close the modal
christine
Phoca Hero
Phoca Hero
Posts: 2738
Joined: 28 Nov 2010, 17:20

Re: 'Close the window' link in download screen

Post by christine »

Hi Jan,

in addition to previous Thread, see this URL: https://www.sgdf-lens.fr/index.php/private-gallery
Thank you.

Christine
User avatar
forlx.62
Phoca Member
Phoca Member
Posts: 21
Joined: 29 Oct 2022, 22:35

Re: 'Close the window' link in download screen

Post by forlx.62 »

In my test site (my laptop), in the class PhocaGalleryRenderDetailButton, i modified the line 351 and set $close to an empty string.

the link disappears

I don't really understand the goal of this link as there is already a "close" button.

I don't know if this function is used somewhere else
christine
Phoca Hero
Phoca Hero
Posts: 2738
Joined: 28 Nov 2010, 17:20

Re: 'Close the window' link in download screen

Post by christine »

Hi,
forlx.62 wrote: 03 Nov 2023, 22:07
I don't really understand the goal of this link as there is already a "close" button.
If I click on the link (button)

Code: Select all

<a style="text-decoration:underline" href="/index.php/private-gallery/573-wp-sonic" onclick="window.parent.SqueezeBox.close();" title="Fermer la fenêtre">Fermer la fenêtre</a>
link, I can see the comments. If I delete this temporarily (with inspector), then they are no longer there. So, why should this be removed?

Kind regards
Christine
User avatar
forlx.62
Phoca Member
Phoca Member
Posts: 21
Joined: 29 Oct 2022, 22:35

Re: 'Close the window' link in download screen

Post by forlx.62 »

Hi Christine,

if i click on the link, the website is displayed in the modal window in which initialy the picture was displayed :Image

if i want to comment the picture, to my point of view, i can close the modal window with the 'close' button on the right-bottom corner, i come back to the category and so i can click on stars or i can click on the comment icon.

in the download window, which is modal, i think i only want to have the feature to download the file.
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 47887
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: 'Close the window' link in download screen

Post by Jan »

Hi,
I don't really understand the goal of this link as there is already a "close" button.
in Phoca Gallery there were different popup methods and not all had/have close button so this is why there is close link. But I will revise it to see if the link is still necessary there. Thank you for the info.

BTW, mostly, for the download icon is direct download used, so there is no popup but direct download.

Jan
If you find Phoca extensions useful, please support the project
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 47887
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: 'Close the window' link in download screen

Post by Jan »

BTW, in next version:

- the link will be removed
- the width of the image will be set to 100%

Image

Jan
If you find Phoca extensions useful, please support the project
User avatar
forlx.62
Phoca Member
Phoca Member
Posts: 21
Joined: 29 Oct 2022, 22:35

Re: 'Close the window' link in download screen

Post by forlx.62 »

Hi Jan,

Ok, so i will wait and apply next updates in this case whereas modify myself the code.

Thanks you
Post Reply