PATCH: Link to section/category

Phoca Download - download manager
jisse
Phoca Newbie
Phoca Newbie
Posts: 6
Joined: 12 Jan 2009, 13:27

Re: PATCH: Link to section/category

Post by jisse »

Hi Jan,

When using JRoute::_() the first argument is a URL without the Itemid. The JRoute::_() function should find the Itemid by itself. In the code of Phoca Download the given URL had the Itemid included, which is unneeded and even unwanted. So I stripped the Itemid part from the URL. After that, JRoute::_() just adds the same Itemid again, but at least that's the correct process.

On the page of multiple items, when there are no items to be shown, I added a small "No items" text.
Jisse Reitsma
Jira ICT founder
SimpleLists developer
busy person
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 48739
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: PATCH: Link to section/category

Post by Jan »

which is unneeded and even unwanted
Hi, this is the compromise because of thousands possible settings of different servers and different SEO (SEF) utils... :-( .... This itemid was added after one year experience of using Phoca Gallery on different servers with different SEF extensions... This itemid doesn't do problems on servers which are running OK but can help a lot of servers where the SEF works incorrectly without this suffix... So it is used in Phoca Download too...

Jan
If you find Phoca extensions useful, please support the project
szablac
Phoca Member
Phoca Member
Posts: 19
Joined: 22 Feb 2009, 00:10
Location: Hungary
Contact:

Re: PATCH: Link to section/category

Post by szablac »

hi Jan,

is there any reason that in the line 16 of router.php is
function PhocaDownloadBuildRoute(&$query) instead of
function PhocaDownloadBuildRoute($query) ?

without that one character the section view works great.
would the solution of this problem be so simple? :?
User avatar
Jan
Phoca Hero
Phoca Hero
Posts: 48739
Joined: 10 Nov 2007, 18:23
Location: Czech Republic
Contact:

Re: PATCH: Link to section/category

Post by Jan »

& this means, that the fuction can change the variable and it returns this variable... if it will be deleted then this function will not return this changed variable and this will be still the same (maybe it works for yur, but mayby it will not work for others)

Jan
If you find Phoca extensions useful, please support the project
Post Reply