Phocagallery plugins

[phproberto]

Hi,

first of all thank you for this great component!

We are developing an integration betweeen phocagallery and hikashop. We need to make some actions before / after a image has been saved. Digging into the code I saw that there is some commented code in administrator/components/com_phocagallery/models/phocagalleryimg.php that triggers some plugin actions. For example:

Code: Select all

		// Trigger the onContentBeforeSave event.
		/*$result = $dispatcher->trigger($this->event_before_save, array($this->option.'.'.$this->name, $table, $isNew));
		if (in_array(false, $result, true)) {
			$this->setError($table->getError());
			return false;
		}*/ 

Are you going to implement it on next releases? As we need it now we are going to add some of them. Do you have any publi repo to commit our changes? We would like to share our improvements to contribute to the component.

Thank you in advance.

Roberto Segura.

[Jan]

Hi, this was removed (commented) because it did conflicts with other extensions

[Silwing]

That is quite sad, such conflicts exists only because of badly written extensions not implementing proper checking of context... Have you considered implementing separate events for before and after save, instead of using the default content events? That should rule out any conflicts.

[Jan]

Hi, I have tested it of course with "own names" but still some extensions had have problems there - it is still under review, so I think, maybe some solution will be found for this issue

Jan