Page 1 of 2
Label can't be assigned
Posted: 11 Apr 2024, 23:05
by Nidzo
Hi Jan, I found one more problem in Phoca Cart Beta versions. Maybe it is just me but I can't assign Label to product. When I hit Save button label selection become unfilled. Tags works O.K.
5.0.0Beta49
Re: Label can't be assigned
Posted: 12 Apr 2024, 15:11
by lpatrick
I can't even find how/where to create Labels.
And you seem to have advanced access to newer beta versions?
Re: Label can't be assigned
Posted: 12 Apr 2024, 16:53
by Nidzo
I download Betas from Phoca github.
https://github.com/PhocaCz/PhocaCart/releases
Labels are "hidden" under Tags. There is option to select Label or Tag
Re: Label can't be assigned
Posted: 12 Apr 2024, 20:43
by lpatrick
Thanks!
I can confirm what you stated, also in Beta 47.
I think there could be an error in libraries/phocacart/tags/tag.php line 47:
Code: Select all
. ' LEFT JOIN ' . self::getRelatedTable($type) . ' AS r ON a.id = r.tag_id';
as $type is an array:
Code: Select all
private static function getProductTags(array $type, $itemId, $select = 0, $checkPublish = 0) {
Because the tags do go into the table _phocacart_tags_related and labels go correctly in _phocacart_taglabels_related.
They are just being incorrectly retrieved IMHO.
Re: Label can't be assigned
Posted: 14 Apr 2024, 01:17
by Jan
Hi, thank you for info, confirmed. I will consult it with other members to solve it (yes, the problem was transforming from integer to array and have the options for this function to load different types)
Thank you, Jan
Re: Label can't be assigned
Posted: 17 Jul 2024, 17:04
by Nidzo
This is still present in the version Phoca Cart v5.0.0 Beta64
Re: Label can't be assigned
Posted: 17 Jul 2024, 21:02
by Nidzo
Well, it can be assigned but it is pretty confusing behaviour.
Latest Phoca Cart v5.0.0. Beta64
Joomla 5.1.2
Created Tag named TAG and label named LABEL and asigned to Ace
Tags and Labels can't be visible together on products image. If Display Labels (Category, Items View) is set to
YES (Tags and labels) only Tags will be shown.
If Display Labels (Category, Items View) is set to
YES only Labels will be shown.
Total confusion starts when Tags (Links) is set to Search Output. I can't even describe it
Re: Label can't be assigned
Posted: 21 Jul 2024, 01:39
by Jan
Hi, thank you for the info, yes, it is now wrong, it is related to changes in multilanguage which then negatively influenced the outcome of the tags/labels. And yes, this feature can be confused, it is based on user's needs where some users want to display tags below and labels above and some want to display tags and labels in the same row, etc.
The correct behaviour (will be set in next version) should be:
Display Labels: Yes (displays labels above the image):
Display Labels: No (does not display labels above the image):
Display Labels: Yes (Tags and Labels) (displays tags and labels in the same position, independent to displayed tags below the image):
(e.g. users want to display tags and labels on the same positon, so they enable the third option and disable the displaying of tags below the image, so tags are not duplicated)
I will do these changes in the next beta.
Thank you, Jan
Re: Label can't be assigned
Posted: 21 Jul 2024, 02:51
by Nidzo
Thanks Jan!
Re: Label can't be assigned
Posted: 22 Jul 2024, 15:34
by Jan
Hi, this should be OK in 5.0.0Beta65:
https://github.com/PhocaCz/PhocaCart/re ... Beta65.zip
- parameters for displaying/hiding labels
- parameters for displaying/hiding tags
- search outcome links for tags and labels
Please test and let me know.
Thank you, Jan