Page 1 of 2

Delete button doesn't work

Posted: 18 Jul 2015, 17:36
by Thomasinho
Hi,

i use Phoca Guestbook 3.0.4 with Joomla 3.4.3.
I noticed that the Delete button doesn't work. It happens in the log section and also in the posts section.
I mark the entry and then click on "Delete" but nothing happens.

Greetings

Re: Delete button doesn't work

Posted: 23 Jul 2015, 23:23
by Jan
Hi, hmm, testing now and both are working OK for me - deleting posts and deleting items in logging just deletes the items.

Which message you get there? When you click on delete button, do you get any javascript error there? See:
https://www.phoca.cz/documents/16-joomla ... -conflicts
Jan

Re: Delete button doesn't work

Posted: 24 Jul 2015, 18:41
by Thomasinho
Ok, i have tested a little bit:

1. FF39 (Firebug):
When i try to delete posts or log entries i get:

Code: Select all

SyntaxError: unterminated string literal
st eine Auswahl in der Liste vornehmen!');}else{if (confirm('\

http://www.teichwirtschaft-koselitz.de/Joomla/administrator/index.php?option=com_phocaguestbook&view=phocaguestbooks
(Row 1, Column 121)
2. IE11 (Development tools):

When i open the posts page, i get:

Code: Select all

SCRIPT1015: Not closed string constant
File: index.php, Row: 473, Column: 2
When i open the log entries page, i get:

Code: Select all

SCRIPT1015: Not closed string constant
File: index.php, Row: 435, Column: 2
3. Chrome 44.0.2403.89 m (64-bit) (Development tools):

When i try to delete posts i get:

Code: Select all

index.php?option=com_phocaguestbook&view=phocaguestbooks:470 Uncaught SyntaxError: Unexpected token ILLEGAL
When i try to delete log entries i get:

Code: Select all

index.php?option=com_phocaguestbook&view=phocaguestbooklogs:433 Uncaught SyntaxError: Unexpected token ILLEGAL
So, in all 3 browsers it does not work and seems like a problem with the closing of the div tag of the delete button. Code looks ok (but i'm no pro-coder).

Re: Delete button doesn't work

Posted: 29 Jul 2015, 08:45
by Jan
Hi, unclosed tag should not be a problem, this seems like something renders the javascript error which then breaks all the javascript functions (e.g. for deleting). Only to be 100%, try to switch to English language so we know there is no problem in german language string (the first code you have pasted)

Jan

Re: Delete button doesn't work

Posted: 29 Jul 2015, 19:49
by Thomasinho
The language was the solution!

When switching to english the deletion of posts and log entries works like it should.

I have exported the Transifex files, renamed them correctly and then uploaded them at the correct folders. I think the problem is that the german word for "Delete" is "Löschen" which contains the "ö", a special character. Maybe a problem with the encoding of the language file?

Re: Delete button doesn't work

Posted: 05 Aug 2015, 00:30
by Jan
Hi, yes, when there is a problem with ö, or ü or ä then this seems like wrong encoding, the language file should be encoded with UTF-8 without BOM :idea:

Jan

Re: Delete button doesn't work

Posted: 05 Aug 2015, 17:56
by Thomasinho
Jan wrote:Hi, yes, when there is a problem with ö, or ü or ä then this seems like wrong encoding, the language file should be encoded with UTF-8 without BOM :idea:

Jan
But the problem is just with the "Löschen" (Delete). The german word for "Publish" is "Veröffentlichen" and there it works perfect.
The downloaded file from transifex is in utf-8 without bom (checked with notepad ++). I just rename the file and upload it and it does not work. I tried Bennos file, copied the content from the downloaded file and it also does not work. But Bennos file is working and he had the same translation for this string. :x :cry:
I'm totally confused. :idea:

Re: Delete button doesn't work

Posted: 08 Aug 2015, 11:24
by Jan
Hi, please let me know the wrong string in INI file (or the line), so I can inform Benno.

Thank you, Jan

Re: Delete button doesn't work

Posted: 08 Aug 2015, 13:27
by christine
Hello,

concerning; "UTF-8 without BOM" > https://github.com/joomla/joomla-cms/pull/6584 since: J 3.4.(2)
regards: Christine

Re: Delete button doesn't work

Posted: 08 Aug 2015, 16:49
by Benno
@Jan,
I understand Thomasinho this way, that the problem exists only in his translation, not in mine.
But Bennos file is working and he had the same translation for this string.
@Thomasinho,
please correct me, if I'm wrong.

I am not able to reproduce the problem with my installed German translation.
See images:
1.)
Image
2.)
Image
3.)
Image

@Thomasinho,
1.) Do you receive any errors, if you enable language debugging?
2.) Perhaps the problem is, why ever, not the language but the manifest file.... ?? :idea:

OT. Hi Christine :)

Kind regards,
Benno