Phoca Forum

Posted: **04 Mar 2012, 18:08**

Hi all, I am using Eclipse IDE for developing the PHP code. I saw a small mistake in the file:
components/com_phocagallery/views/category/tmpl/default_statistics.php

Can the developers apply this after approval to the next release?

Here's my small patch:

Code: Select all

Index: default_statistics.php
===================================================================
--- default_statistics.php	(revision 2)
+++ default_statistics.php	(working copy)
@@ -50,7 +50,7 @@
 									echo JHTML::_( 'image.site', $value->linkthumbnailpath, '', '', '', $value->altvalue, array('class' => 'pg-image'));
 								}
 
-								?></a>
+								?>></a>
 								
 							</div>
 						</div>
@@ -129,7 +129,7 @@
 								} else {
 									echo JHTML::_( 'image', $value->linkthumbnailpath, $value->altvalue, array('class' => 'pg-image') );
 								}
-								?></a>
+								?>></a>
 								
 							</div>
 						</div>

Also some divs were not closed, but I couldn't check how they should be closed, so I didn't fix that.
Thanks all! Keep up the good work

Posted: **07 Mar 2012, 02:32**

Hi, which version is this?

Posted: **18 Mar 2012, 15:07**

Version 3.1.5 of Phoca Gallery. Thanks for fixing this.

Posted: **19 Mar 2012, 22:42**

Hi, I don't understand your changes.

A tag is closed on line 46:

echo ' >';

why to close it again and in fact close the image tag as attribute into a tag on line 50?

Posted: **20 Mar 2012, 10:42**

You're right. The tag is opened in HTML but closed in the echo command. So my patch doesn't fix/repair it.
But the PHP-file itself is harder to validate for IDEs, because the HTML itself is not valid, because of the missing closing tag, which is added by code.

Posted: **21 Mar 2012, 23:52**

Hmm, I don't see there any closed tag?

Phoca Forum

Small code fix patch

Small code fix patch

Re: Small code fix patch

Re: Small code fix patch

Re: Small code fix patch

Re: Small code fix patch

Re: Small code fix patch