Page 1 of 1

plugin v1.3.6, CSS-Validator error

Posted: 27 Dec 2010, 23:36
by Ray
Hello, Jan!

The browser is Opera 10.63. I have added this command in content:

Code: Select all

{phocadownload view=file|id=1}
And I can see a small error in the row num 468.

/public_html/plugins/content/phocadownload.php:

Code: Select all

$output .= '<div class="phocadownloadfile'.(int)$iSize.'"><a href="'. JRoute::_($link).'" '.$targetOutput.'>'. $textOutput.'</a></div>';
I have solved it by adding the element <object></object>:

Code: Select all

$output .= '<object><div class="phocadownloadfile'.(int)$iSize.'"><a href="'. JRoute::_($link).'" '.$targetOutput.'>'. $textOutput.'</a></div></object>';
Best regards, Ray

Re: plugin v1.3.6, CSS-Validator error

Posted: 28 Dec 2010, 14:21
by Jan
Ok

Re: plugin v1.3.6, CSS-Validator error

Posted: 28 Dec 2010, 21:54
by Ray
But with this IE8 doesn't show the link for download (white square). In Opera is ok, but with error in css. I have rolled back the code (without <object>)..

Re: plugin v1.3.6, CSS-Validator error

Posted: 01 Jan 2011, 23:17
by Jan
Hi, in fact the CSS validity does not solve anything, there is no reason to follow it.

E.g. these days, the modern sites are displayed rounded corners with e.g. shadow boxes - all this can be done in css (no background images, no hacks) but such css rules are not valid. But they are SEO friendly - you save a lot of resources, because instead of loading background images, making 4 divs instead of one, etc. you only give easy rules to CSS.

This:
-moz-border-radius: 5px;
-webkit-border-radius: 5px;
border-radius: 5px;
is not CSS valid but display rounded corners in all standard browsers (without any hacks - border images, 4 divs instead of one, etc.)

Jan