Page 2 of 2

Re: PATCH: Link to section/category

Posted: 05 Feb 2009, 15:24
by jisse
Hi Jan,

When using JRoute::_() the first argument is a URL without the Itemid. The JRoute::_() function should find the Itemid by itself. In the code of Phoca Download the given URL had the Itemid included, which is unneeded and even unwanted. So I stripped the Itemid part from the URL. After that, JRoute::_() just adds the same Itemid again, but at least that's the correct process.

On the page of multiple items, when there are no items to be shown, I added a small "No items" text.

Re: PATCH: Link to section/category

Posted: 08 Feb 2009, 23:43
by Jan
which is unneeded and even unwanted
Hi, this is the compromise because of thousands possible settings of different servers and different SEO (SEF) utils... :-( .... This itemid was added after one year experience of using Phoca Gallery on different servers with different SEF extensions... This itemid doesn't do problems on servers which are running OK but can help a lot of servers where the SEF works incorrectly without this suffix... So it is used in Phoca Download too...

Jan

Re: PATCH: Link to section/category

Posted: 22 Feb 2009, 00:38
by szablac
hi Jan,

is there any reason that in the line 16 of router.php is
function PhocaDownloadBuildRoute(&$query) instead of
function PhocaDownloadBuildRoute($query) ?

without that one character the section view works great.
would the solution of this problem be so simple? :?

Re: PATCH: Link to section/category

Posted: 24 Feb 2009, 19:33
by Jan
& this means, that the fuction can change the variable and it returns this variable... if it will be deleted then this function will not return this changed variable and this will be still the same (maybe it works for yur, but mayby it will not work for others)

Jan