Page 1 of 1

Bug when name is not set

Posted: 27 Mar 2019, 23:25
by tr4kx
Hi,

Thanks for your great job. Newsletter component works well. I just found a small bug with the component and joomla 3.

If subscriber has not set its name, trying to unsubscribe leads to an error message. But the user is unsubscribed successfully.
I the user set its name, no more bug...

Thank you.

Re: Bug when name is not set

Posted: 31 Mar 2019, 17:21
by Jan
Hi, thank you for the info, I will take a look at it for the next version.

Thank you, Jan

Re: Bug when name is not set

Posted: 08 Apr 2019, 22:45
by tr4kx
Hi Jan,

During unsubscribe, there a test checking if the variable with the name is not empty. Remove this check could remove the bug.
File to modify is /administrator/components/com_phocaemail/helpers/phocaemailsendnewsletteremail.php

Change line n°262:

Code: Select all

if ($rows > 0 && isset($subscriber->name) && isset($subscriber->email) && $subscriber->name != '' && $subscriber->email != '')  {
with

Code: Select all

if ($rows > 0 && isset($subscriber->name) && isset($subscriber->email) && $subscriber->email != '')  {
Not sure it's the best way but it works. I hope it'll help.

Re: Bug when name is not set

Posted: 10 Apr 2019, 21:30
by Jan
Hi, thank you very much for the info, I will revise it for next version.

Thank you, Jan

Re: Bug when name is not set

Posted: 22 Jun 2020, 11:48
by Jan